Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 rewrite create commands #864

Merged
merged 7 commits into from
Jan 16, 2024
Merged

feat: 🎸 rewrite create commands #864

merged 7 commits into from
Jan 16, 2024

Conversation

sunny0826
Copy link
Owner

@sunny0826 sunny0826 commented Jan 16, 2024 •
edited
Loading

Description

Related Issue

#788

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@the-label-bot the-label-bot bot added the size/L size/L label Jan 16, 2024
@the-label-bot The Label Bot
Copy link

the-label-bot bot commented Jan 16, 2024 •
edited
Loading

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.603 ✔️
Size L 0.973 ✔️

@sunny0826 sunny0826 self-assigned this Jan 16, 2024
@sunny0826 sunny0826 changed the title Feat/creat feat: 🎸 rewrite create commands Jan 16, 2024
@the-label-bot the-label-bot bot added the kind/feature ategorizes issue or PR as related to a new feature. label Jan 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Comparison is base (5cd1b02) 19.28% compared to head (54e16ac) 19.46%.
Report is 4 commits behind head on master.

Files Patch % Lines
cmd/create.go 1.86% 158 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   19.28%   19.46%   +0.18%     
==========================================
  Files          21       21              
  Lines        2271     2368      +97     
==========================================
+ Hits          438      461      +23     
- Misses       1792     1865      +73     
- Partials       41       42       +1
Flag Coverage Δ
unittests 19.46% <1.86%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitguardian GitGuardian
Copy link

gitguardian bot commented Jan 16, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sunny0826 sunny0826 changed the title feat: 🎸 rewrite create commands [WIP]feat: 🎸 rewrite create commands Jan 16, 2024
@sunny0826 sunny0826 changed the title [WIP]feat: 🎸 rewrite create commands feat: 🎸 rewrite create commands Jan 16, 2024
@sunny0826 sunny0826 merged commit 2949516 into master Jan 16, 2024
6 checks passed
@sunny0826 sunny0826 deleted the feat/creat branch January 16, 2024 08:26
This was referenced Jan 17, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sunny0826 sunny0826

Labels
kind/feature ategorizes issue or PR as related to a new feature. size/L size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sunny0826